1. Having troubles with activation email? Contact us at: Contact@FaceRig.us
    Dismiss Notice
  2. Hey Guest! We are giving away a FREE copy of FaceRig to one lucky member of FaceRig.US!!! Check out how you can get it by clicking here: http://facerig.us/index.php?threads/win-facerig-free.271
    Dismiss Notice
  3. It costs money to keep the site afloat. Guest, if you'd like to help us out and donate even $1 it will go a long way! Donate here:
    Dismiss Notice
  4. This is the fan-made / managed forum, for sharing community made content (avatars / props) The site owned / managed by the creators is https://facerig.com (currently down, we are working on it) The Steam forums are on http://steamcommunity.com/app/274920/discussions/
    Dismiss Notice

Minor Alerts link issue

Discussion in 'Archive' started by SnoFox, Jan 15, 2014.

Thread Status:
Not open for further replies.
  1. SnoFox
    Busy
    Offline

    SnoFox Common Minion

    Messages:
    15
    Ratings:
    +2 / 0 / -0
    FR$:
    $0
    Yo,

    I have a bone to pick with you, Xyphien. Not just any bone, but an extremely minor bone.

    The Alerts link in the top right, when clicked, will open part of the Alert message off-browser to the right. This happens regardless if my browser is windowed or maximized. It's not a huge issue, simply that it requires me to scroll to the right to view the alerts. Which is a surprising amount of effort. I have to move my mouse all the way to the horizontal scroll bar at the bottom of the screen...

    #FirstWorldProblems

    Technical information:
    Code:
    [josh@mockingjay ~]$ google-chrome --version                          [ 8:08PM]
    Google Chrome 31.0.1650.63 
    [josh@mockingjay ~]$ lsb_release -irc                                 [ 8:08PM]
    Distributor ID:	LinuxMint
    Release:	14
    Codename:	nadia
    Also, you REALLY want to change the CSS for the code block ... Light gray on White... Tsk tsk.
     
  2. Xyphien
    Swamped
    Offline

    Xyphien Administrator Staff Member Administrator

    Messages:
    491
    Ratings:
    +113 / 0 / -0
    FR$:
    $124
    UGH!!! I just fixed the quote box CSS... now I have to do the Code box too... XD

    Also, I'll fix that hopefully soon as well lol. I don't have that problem because I have ModCP and AdminCP before the alerts XD
     
  3. Xyphien
    Swamped
    Offline

    Xyphien Administrator Staff Member Administrator

    Messages:
    491
    Ratings:
    +113 / 0 / -0
    FR$:
    $124
    And... I fixed it :)
     
  4. SnoFox
    Busy
    Offline

    SnoFox Common Minion

    Messages:
    15
    Ratings:
    +2 / 0 / -0
    FR$:
    $0
    Thank you! :D

    Also side note, the Alerts box has the same, bright CSS from my original screenshot. That bothers me less as it's less prominently used. And, and! Your "Thanks" plugin will display a comma even if only one user "Thanked" a post.

    I will nit-pick until you hate me. :]

    Edit: For some reason this post is showing a blank "Thanked by: " field.
     
  5. Xyphien
    Swamped
    Offline

    Xyphien Administrator Staff Member Administrator

    Messages:
    491
    Ratings:
    +113 / 0 / -0
    FR$:
    $124
    No, nit-picking is completely fine :) It allows me to know what's wrong, and what to fix. As for the comma, that's something that is built in for all thanked posts, editing that will simply remove it for everyone. So if you and I liked a post, instead of it being Xyphien, SnoFox, liked this post. I'd be Xyphien SnoFox Liked this post.
     
  6. FurRiffic
    Zorro
    Offline

    FurRiffic Administrator Staff Member Administrator

    Messages:
    215
    Ratings:
    +42 / 0 / -0
    FR$:
    $36
    Not sure how forum code 100% works but couldn't you do something like this:

    (Notice, this is pseudo-code)

    string thanksLineString = ""
    for each thankingUser in thankList do
    {
    thanksLineString = thanksLineString + thanksingUser + ","
    }
    thanksLineString = Split(thanksLineString; 0; (thanksLineString.Length - 1))
    If (thanksLineString <> "")
    {
    showThanksBelowPost(thanksLineString)
    }

    Hereby the split method is (string to split;starting symbol; number of symbols)
     
  7. SnoFox
    Busy
    Offline

    SnoFox Common Minion

    Messages:
    15
    Ratings:
    +2 / 0 / -0
    FR$:
    $0
    I'm aware that it's part of the module/plugin. It'd be a very simple modification if you were up to it.

    Since we're doing patches, here's the algorithm I use in every language for comma separated lists:

    Code:
    // Assuming PHP since forum software
    // Assuming the users who thanked you are returned in an array structure
    $comma = false;
    $outstr = "";
    foreach($thankingUsers as $user) {
      if($comma) $outstr .= ", ";
      $comma = true;
      $outstr .= $user;
    }
    
     
Thread Status:
Not open for further replies.

Share This Page